ENH: xz compression_args df.to_pickle(path, compression={'method':'xz','pr… #53443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/io/common.py:829:89: E501 Line too long (103 > 88 characters)
segatrade
changed the title
Member
|
Thank you for the PR. You definitely will need the following:
|
pandas/io/common.py:830: error: Argument 1 to "LZMAFile" has incompatible type "Union[str, BaseBuffer]"; expected "Optional[Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[bytes]]]" [arg-type] pandas/io/common.py:831: error: Unused "type: ignore" comment
Contributor
Author
|
Thank you for advices and maintaining pandas! Seems done with checks and docs. Do I need add any new tests or it's ready? |
twoertwein
reviewed
May 30, 2023
Member
Yes, you will need a test. Probably in https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/test_compression.py I'm not sure how to best test that the keywords are being forwarded: maybe one test with either to_pickle/read_csv and just pass a valid argument and then another test that passes an invalid keyword that raises an error in lzma to ensure the keyword is forwarded to it. edit: should probably test both to_pickle and read_csv just to cover one read/write method. |
docs ench update
sort whatsnew entries alphabetically & black fix
twoertwein
reviewed
Jun 2, 2023
Contributor
Author
|
Thank you! Done. Seems now everything is ready for review. |
twoertwein
approved these changes
Jun 2, 2023
mroeschke
approved these changes
Jun 2, 2023
Member
|
Thanks @segatrade |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
…','pr… (pandas-dev#53443) * xz compression_args df.to_pickle(path, compression={'method':'xz','preset': 9}) * fix Line too long pandas/io/common.py:829:89: E501 Line too long (103 > 88 characters) * fix black * xz compression_args docs * ruff 458:89: E501 Line too long * fix mypy Failed pandas/io/common.py:830: error: Argument 1 to "LZMAFile" has incompatible type "Union[str, BaseBuffer]"; expected "Optional[Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[bytes]]]" [arg-type] pandas/io/common.py:831: error: Unused "type: ignore" comment * xz compression tests docs ench update * Sphinx lint & black fix * additional assert in test sort whatsnew entries alphabetically & black fix * fix test obj * fix path test * removed test_xz_compression_invalid_args , fix read_csv(compression --------- Co-authored-by: Se <--global>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…','pr… (pandas-dev#53443) * xz compression_args df.to_pickle(path, compression={'method':'xz','preset': 9}) * fix Line too long pandas/io/common.py:829:89: E501 Line too long (103 > 88 characters) * fix black * xz compression_args docs * ruff 458:89: E501 Line too long * fix mypy Failed pandas/io/common.py:830: error: Argument 1 to "LZMAFile" has incompatible type "Union[str, BaseBuffer]"; expected "Optional[Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[bytes]]]" [arg-type] pandas/io/common.py:831: error: Unused "type: ignore" comment * xz compression tests docs ench update * Sphinx lint & black fix * additional assert in test sort whatsnew entries alphabetically & black fix * fix test obj * fix path test * removed test_xz_compression_invalid_args , fix read_csv(compression --------- Co-authored-by: Se <--global>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eset': level})
level = 9
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.