DEPR: Deprecate literal json string input to read_json #53409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g is passed to read_json
…g is passed to read_json
rmhowe425
changed the title
|
Code Checks / Docstring validation, typing, and other manual pre-commit hooks (pull_request) test failing seems to be unrelated to changes in my PR. Doc Build and Upload seems to be failing because the CI test itself passes literal JSON strings to |
rmhowe425
changed the title
|
@mroeschke Would you be able to take a look at this PR and let me know if anything needs updating? |
mroeschke
reviewed
May 30, 2023
mroeschke
reviewed
May 30, 2023
mroeschke
reviewed
May 30, 2023
mroeschke
requested changes
May 30, 2023
mroeschke
added
IO JSON
mroeschke
reviewed
May 30, 2023
mroeschke
reviewed
May 30, 2023
mroeschke
reviewed
May 30, 2023
|
@mroeschke This PR should be ready for review! |
|
@mroeschke Should be good to go now. |
|
Looks like some of the code checks are still failing in the CI |
|
@mroeschke Code Checks / Docstring validation passing now. Docbuild and upload test failure doesn't appear to be associated with PR |
|
You may want to check usage of |
|
@mroeschke Pinging on green! |
|
@mroeschke Should be good to go now! |
mroeschke
approved these changes
Jun 20, 2023
|
Thanks @rmhowe425 |
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
) * Adding logic to throw a deprecation warning when a literal json string is passed to read_json * Adding logic to throw a deprecation warning when a literal json string is passed to read_json * Updating documentation and adding PR num to unit test * Adding a deprecation warning to the user guide * Updating unit tests to check for FutureWarning * Fixing unit tests * Fixing unit tests * Fixing unit tests * Fixing unit tests * Fixing documentation errors in PR feedback * Fixing documentation errors in PR feedback * Updating unit tests to use StringIO rather than catch FutureWarning * Finishing updating unit tests to use StringIO rather than catch FutureWarning * Fixing indendation errors in unit tests. Moved one unit test to another file. * Updating unit test name * Adding additional checks to unit tests * Fixing unit tests * Fixing unit tests * Updating whatsnew documentation per reviewer recommendations. * Fixing failing code tests * Fixing failing code tests * Adding import to doc string example * Fixing documentation formatting error * Fixing documentation formatting error * Fixing documentation error after fixing merge conflict * Fixing formatting errors in whatsnew file * Updating formatting errors in documentation * Updating formatting errors in documentation
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
) * Adding logic to throw a deprecation warning when a literal json string is passed to read_json * Adding logic to throw a deprecation warning when a literal json string is passed to read_json * Updating documentation and adding PR num to unit test * Adding a deprecation warning to the user guide * Updating unit tests to check for FutureWarning * Fixing unit tests * Fixing unit tests * Fixing unit tests * Fixing unit tests * Fixing documentation errors in PR feedback * Fixing documentation errors in PR feedback * Updating unit tests to use StringIO rather than catch FutureWarning * Finishing updating unit tests to use StringIO rather than catch FutureWarning * Fixing indendation errors in unit tests. Moved one unit test to another file. * Updating unit test name * Adding additional checks to unit tests * Fixing unit tests * Fixing unit tests * Updating whatsnew documentation per reviewer recommendations. * Fixing failing code tests * Fixing failing code tests * Adding import to doc string example * Fixing documentation formatting error * Fixing documentation formatting error * Fixing documentation error after fixing merge conflict * Fixing formatting errors in whatsnew file * Updating formatting errors in documentation * Updating formatting errors in documentation
3 tasks
galipremsagar
added a commit
to rapidsai/cudf
that referenced
this pull request
Dec 13, 2023
This PR deprecates reading literal strings in read_json, instead users will need to pass StringIO for these cases to silence the warning. This change is to match: pandas-dev/pandas#53409 On pandas_2.0_feature_branch: = 501 failed, 101106 passed, 2071 skipped, 786 xfailed, 312 xpassed, 20 errors in 1234.91s (0:20:34) = This PR: = 426 failed, 101181 passed, 2091 skipped, 786 xfailed, 312 xpassed in 1126.93s (0:18:46) =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_json#52271doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.