-
-
Couldn't load subscription status.
- Fork 19.2k
add concat function dtype test #51816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
009cdab to
b25b0b2
Compare
|
1 check failed with current code,Ubuntu/Data Manager. It means that the code |
| df_time = pd.DataFrame({"A": pd.array(["2000"], dtype="datetime64[ns]")}) | ||
| df_float = pd.DataFrame({"A": pd.array([1.0], dtype="float64")}) | ||
|
|
||
| tm.assert_equal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each of these:
- Could you use
tm.assert_frame_equal - Create variables
expected = ... , result = ...
085a22e to
f97b6d4
Compare
|
Looks like the |
f97b6d4 to
539caf2
Compare
| assert all(td._value == 0 for td in result2.ravel()) | ||
|
|
||
|
|
||
| def test_concat_float_datetime64(using_array_manager): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this test to pandas/tests/reshape/concat/test_datetimes.py? After that this looks good
Signed-off-by: Liang Yan <[email protected]>
539caf2 to
0294325
Compare
|
It seems that another numpy error in "Ubuntu / Numpy Dev(pull_request)". |
|
Thanks @liang3zy22 (that failure is unrelated) |
The old PR closed, so created new one to close #32934.