TST: Test to verify behavior of groupby.std with no numeric columns and numeric_only=True #51761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 2, 2023 17:29
…pby-std-numeric-only-tests
…umanIjaz/pandas into groupby-std-numeric-only-tests
rhshadrach
requested changes
Mar 4, 2023
pandas/core/groupby/groupby.py
Outdated
| numeric_only : bool, default False | ||
| Include only `float`, `int` or `boolean` data. | ||
| Include only `float`, `int` or `boolean` columns. |
Member
There was a problem hiding this comment.
I believe data is used here because this docstring is shared by DataFrameGroupBy and SeriesGroupBy; the latter does not have columns. I think this should be reverted.
Contributor
Author
There was a problem hiding this comment.
Makes sense. I have reverted these changes. But should't we have separate docstrings for DataFrameGroupBy and SeriesGroupBy for more clarity?
Member
There was a problem hiding this comment.
We could template these docstrings or just separate them out entirely; but that should be a separate PR.
mroeschke
added
Testing
Member
|
Thanks @numanijaz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.