- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 19.2k
DEPR: Enforce ewm(times=str) deprecation #48842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Test that it raises? Whatsnew? | 
| 
 | 
            
                  jbrockmendel
  
            
            approved these changes
            
                
                  Oct 20, 2022 
                
            
            
          
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
            
                  phofl
  
            
            reviewed
            
                
                  Oct 20, 2022 
                
            
            
          
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typing needs fixing, otherwise lgtm
    
  phofl 
      pushed a commit
        to phofl/pandas
      that referenced
      this pull request
    
      Oct 21, 2022 
    
    
      
  
    
      
    
  
* DEPR: Enforce ewm(times=str) deprecation * Fix typing * Fix test * convert test to raises * Add whatsnew * Fix typing * fix typing
    
  noatamir 
      pushed a commit
        to noatamir/pandas
      that referenced
      this pull request
    
      Nov 9, 2022 
    
    
      
  
    
      
    
  
* DEPR: Enforce ewm(times=str) deprecation * Fix typing * Fix test * convert test to raises * Add whatsnew * Fix typing * fix typing
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Introduced in #43265