TST: dt.total_seconds() stores float with appending 0.00000000000001 fix #48218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntachukwu
commented
Aug 23, 2022
ntachukwu
commented
- closes dt.total_seconds() stores float with appending 0.00000000000001 #34290
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
Test for dt.total_seconds() stores float with appending 0.00000000000001 fix
mroeschke
added
Testing
mroeschke
requested changes
Aug 23, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Could you add this simpler test instead? #34290 (comment)
mroeschke
approved these changes
Aug 25, 2022
Member
|
Thanks @Th3nn3ss |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…fix (pandas-dev#48218) * TST GH34290 Test for dt.total_seconds() stores float with appending 0.00000000000001 fix * simpler test * use Timedelta instead of pd.Timedelta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.