-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
date_range should (at least optionally) deal with right-open intervals #4579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@filmor you can submit a PR if you would like, but this is essentially label based indexing, so the python convention doesn't apply here. That side, having a |
|
I still have to build some test-cases for the new inputs before this is ready for merge. |
|
I think |
|
The current commit contains a release note, but I don't understand your comment on the parameter. What is wrong with being able to have open, left-open, right-open and closed intervals? There are uses for all of them and the interface seems pretty obvious to me … |
|
take a look at
can't change the API ATM different from what exists in the rest of pandas. |
|
@filmor need some tests for this; e.g. with closed taking on each value and that the generated range is correct (for several freqs should be good). should go in |
|
Could you have a look at the Travis output? An error occurs in a place, where I didn't change anything(tm), for some reason the |
|
@filmor did you fix the bug? |
|
@filmor how's this coming? |
|
thanks for the PR! |
It is confusing that, albeit the name suggests otherwise,
date_rangebehaves differently compared to the standard Pythonrangegenerator in that it returns the right-closed interval.