REF: make Block.delete return a new Block #45689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Internals
mroeschke
reviewed
Jan 30, 2022
| self._blklocs[blk.mgr_locs.indexer] = np.arange(len(blk)) | ||
| nb = blk.delete(blk_locs) | ||
| blocks_tup = ( | ||
| self.blocks[:blkno_l] + (nb,) + self.blocks[blkno_l + 1 :] |
Member
There was a problem hiding this comment.
blkno_l is never negative here right?
mroeschke
approved these changes
Jan 30, 2022
Contributor
Member
Author
Yes. These were fixed in #45707 |
Member
Author
|
Nice. Now #45352 is all that's left between us and block.values being immutable |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost track of the original use case that motivated this, but in general i think we're better off keeping block.values fixed.