-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test Python 3.10 on MacOS and Windows too #43772
Conversation
New Windows failures :(
No details because it raised in Cython code. I'll try to fix it. EDIT: Apparantly this test is xfailed on Windows, but for some reason the xfail doesn't trigger on Python 3.10 b/c the exception isn't getting raised properly. I guess I'll just skip the test. |
@github-actions pre-commit |
pip install git+https://github.com/nedbat/coveragepy.git | ||
pip install cython python-dateutil pytz hypothesis pytest-xdist pytest-cov | ||
pip install cython python-dateutil pytz hypothesis pytest>=6.2.5 pytest-xdist pytest-cov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this in our requirements-dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its 6.0 in requirements dev. 6.2.5 is the first version to support python 3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok got it, can you update whatsnew with this as well
more complex, but could maybe retain the xfail for Python 3.8 and 3.9 and skip for py3.10 with a comment back to this issue. |
This is okay to backport? |
yeah i think ok to backport |
thanks @lithomas1 |
@meeseeksdev backport 1.3.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
cc @lithomas1 if you'd do the manual backport when you have a chance |
Blocker for MacOS/Windows Python 3.10 wheels. We probably want to migrate these onto Azure as soon as Python 3.10 is available there for load balancing reasons.