Skip to content

TST: added test for groupby when calling first, last, nth (GH29645) #43358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2021
Merged

TST: added test for groupby when calling first, last, nth (GH29645) #43358

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8379f11
TST: added test for groupby when calling first, last, nth (GH29645)
lorenzophys Sep 2, 2021
384d32f
TST: code review, explicit expected, parametrized over nans
lorenzophys Sep 2, 2021
a9646d8
TST: code review, check for value, use nulls_fixture
lorenzophys Sep 2, 2021
2636ad7
TST: code review, moved test to test_nth.py
lorenzophys Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,3 +2419,22 @@ def test_rolling_wrong_param_min_period():
result_error_msg = r"__init__\(\) got an unexpected keyword argument 'min_period'"
with pytest.raises(TypeError, match=result_error_msg):
test_df.groupby("name")["val"].rolling(window=2, min_period=1).sum()


@pytest.mark.parametrize("method", ["first", "last", "nth"])
Copy link
Contributor

@jreback jreback Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move to test_nth.py

Copy link
Contributor Author

@lorenzophys lorenzophys Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

@pytest.mark.parametrize("nans", [None, np.nan])
def test_groupby_last_first_nth_with_none(method, nans):
# GH29645
expected = Series([True])
data = (
Series([nans, "x", nans, "y", nans], index=[0, 0, 0, 0, 0])
.isna()
Copy link
Member

@phofl phofl Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think isna is necessary.

Does parametrization over all missing values work? pd.NA, NaT etc

Copy link
Contributor Author

@lorenzophys lorenzophys Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean something like @pytest.mark.parametrize("nans", [None, np.nan, pd.NA, pd.NaT]) without isna then no, all tests fail. They all pass if isna is there

Copy link
Member

@phofl phofl Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you check the same as in #29645 (comment)? We do not want to check for True False rather than for "y".

We have a missing value fixture, but yes I meant like this

Copy link
Contributor Author

@lorenzophys lorenzophys Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable, I misunderstood

.groupby(level=0)
)

if method == "nth":
result = getattr(data, method)(2)
else:
result = getattr(data, method)()

tm.assert_series_equal(result, expected)