Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: remove ignores for "Cannot assign to a method" #40265

Merged

Conversation

simonjayhawkins
Copy link
Member

xref #37715

This is dynamic generated code. so I am also OK with leaving theses ignores in play to highlight this. these mypy errors could be interpreted as not being false positives.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Mar 6, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Mar 6, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit 1c38dfa into pandas-dev:master Mar 8, 2021
@jreback
Copy link
Contributor

jreback commented Mar 8, 2021

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the Cannot-assign-to-a-method branch March 8, 2021 15:08
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants