Skip to content

Conversation

@jbrockmendel
Copy link
Member

Also some annotations and "pragma: no cover" for cases that are also checked by mypy


if seen_tz_naive and seen_tz_aware:
return 'mixed'
return "mixed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @MarcoGorelli would not be averse to a pre-commit to make sure quoting is uniform per file (e.g. either ' or "), ideally we should just be uniform across the entire codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black ensures we use double in the python code; the cython is a mishmash but mostly double at this point

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Feb 27, 2021
@jreback jreback added this to the 1.3 milestone Feb 27, 2021
@jreback jreback merged commit a11dc79 into pandas-dev:master Feb 27, 2021
@jbrockmendel jbrockmendel deleted the cln-convert_dates branch November 20, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants