ASV: add benchmarks for concatenating and appending of CategoricalIndex (GH38149) #39493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avinashpancham
commented
Jan 30, 2021
avinashpancham
commented
- closes ASV: add benchmark for concat / append of casted categorical #38149
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Feb 2, 2021
asv_bench/benchmarks/categoricals.py
Outdated
| def time_sort_values(self): | ||
| self.index.sort_values(ascending=False) | ||
|
|
||
| def time_append_index(self): |
Contributor
There was a problem hiding this comment.
can you put these with the append/concat ones instead
jreback
added
Benchmark
jreback
approved these changes
Feb 7, 2021
Contributor
|
thanks @avinashpancham |
CyberQin
pushed a commit
to CyberQin/pandas
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.