Skip to content

REF: simplify _get_empty_dtype_and_na #39453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 5 commits into from
Feb 2, 2021
Merged

REF: simplify _get_empty_dtype_and_na #39453

jreback merged 5 commits into from
Feb 2, 2021
+45 −32

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 28, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Jan 29, 2021
@jreback
Copy link
Contributor

jreback commented Jan 29, 2021

can you rebase as i think we merged some of the prior ones

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 29, 2021

can you rebase as i think we merged some of the prior ones

git is telling me this is up to date (though github is showing me a weird diff)

@jreback
Copy link
Contributor

jreback commented Jan 29, 2021

can you rebase as i think we merged some of the prior ones

git is telling me this is up to date (though github is showing me a weird diff)

hmm interesting, i see pieces of several merged PRs AFAICT

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 29, 2021

ill force push to be on the safe side

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 29, 2021

rebased + green

@jbrockmendel jbrockmendel mentioned this pull request Feb 1, 2021
Merged
@jreback jreback mentioned this pull request Feb 1, 2021
Merged
4 tasks
@jreback
Copy link
Contributor

jreback commented Feb 2, 2021

i think merge master as other things have been merged which touch this

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Feb 2, 2021

i think merge master as other things have been merged which touch this

rebased 2 hours ago, following #39454, so we should be good here

@jreback jreback added this to the 1.3 milestone Feb 2, 2021
@jreback jreback added the Internals Related to non-user accessible pandas implementation label Feb 2, 2021
@jreback jreback merged commit 5e02681 into pandas-dev:master Feb 2, 2021
@jbrockmendel jbrockmendel deleted the ref-concat-internals-3 branch February 2, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Dtype Conversions Unexpected or buggy dtype conversions Internals Related to non-user accessible pandas implementation

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback