Skip to content

TST: Inconsistent behavior of .replace() in Int64 series with NA #38693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 28, 2020
Merged

TST: Inconsistent behavior of .replace() in Int64 series with NA #38693

Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
39ec797
pandas-dev issue #38267
ftrihardjo Dec 25, 2020
a83dbcb
pandas-dev issue #38267
ftrihardjo Dec 25, 2020
3db04e7
pandas-dev issue #38267
ftrihardjo Dec 26, 2020
b8ccce5
pandas-dev issue #38267
ftrihardjo Dec 26, 2020
9b3f075
pandas-dev issue #38267
ftrihardjo Dec 26, 2020
9d437ec
pandas-dev issue #38267
ftrihardjo Dec 26, 2020
76e2fa6
pandas-dev issue #38267
ftrihardjo Dec 27, 2020
6320412
pandas-dev issue #38267
ftrihardjo Dec 27, 2020
a5dc3c4
pandas-dev issue #38267
ftrihardjo Dec 27, 2020
ced83a6
pandas-dev issue #38267
ftrihardjo Dec 27, 2020
d486750
pandas-dev issue #38267
ftrihardjo Dec 27, 2020
d11fddc
pandas-dev issue #38267
ftrihardjo Dec 28, 2020
778392c
pandas-dev issue #38267
ftrihardjo Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/tests/series/methods/test_replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,13 @@ def test_replace_with_dict_with_bool_keys(self):
expected = pd.Series(["yes", False, "yes"])
tm.assert_series_equal(result, expected)

@pytest.mark.parametrize("dtype", ["int8", "int16", "int32", "int64"])
Copy link
Member

@MarcoGorelli MarcoGorelli Dec 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the types need to be capitalised, as in the issue, e.g. Int64 not int64

def test_replace_int_with_na(self, dtype):
Copy link
Contributor

@arw2019 arw2019 Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use any_nullable_int_dtype fixture here

Copy link
Contributor

@arw2019 arw2019 Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it test_replace_nullable_int_with_na or test_replace_Int_with_na

# GH 38267
result = pd.Series([0, None]).astype(dtype).replace(0, pd.NA)
Copy link
Contributor

@arw2019 arw2019 Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass dtype directly to the Series constructor

expected = pd.Series([0, None]).astype(dtype).fillna(0).replace(0, pd.NA)
Copy link
Member

@MarcoGorelli MarcoGorelli Dec 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to construct expected directly (e.g. expected = pd.Series([pd.NA, pd.NA]))?

tm.assert_series_equal(result, expected)

def test_replace2(self):
N = 100
ser = pd.Series(np.fabs(np.random.randn(N)), tm.makeDateIndex(N), dtype=object)
Expand Down