Skip to content

TST: Add test for missing fillvalue in categorical dtype #37720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

TST: Add test for missing fillvalue in categorical dtype #37720

merged 1 commit into from
Nov 9, 2020

Conversation

@phofl
Copy link
Member

@phofl phofl commented Nov 9, 2020

cc @jreback Could not find a test for something similar with reindex.

@phofl phofl added Categorical Categorical Data Type Needs Tests Unit test(s) needed to prevent regressions labels Nov 9, 2020
@jreback jreback added this to the 1.2 milestone Nov 9, 2020
@jreback jreback merged commit 75eb0cf into pandas-dev:master Nov 9, 2020
@jreback
Copy link
Contributor

jreback commented Nov 9, 2020

thanks!

@phofl phofl deleted the 18185 branch November 9, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Categorical Categorical Data Type Needs Tests Unit test(s) needed to prevent regressions

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

Trying to reindex category Series with invalid fill_value raises error without message

2 participants

@phofl @jreback