Skip to content

Conversation

@arw2019
Copy link
Contributor

@arw2019 arw2019 commented Oct 17, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

xref #36985 (comment)

@arw2019 arw2019 marked this pull request as draft October 17, 2020 01:54
@arw2019 arw2019 marked this pull request as ready for review October 17, 2020 02:28
@arw2019
Copy link
Contributor Author

arw2019 commented Oct 17, 2020

@jbrockmendel @jreback this is the follow-up to #36985. It seems like it's ok to just drop the special casing for EAs in maybe_casted_values

@jreback jreback added Clean Dtype Conversions Unexpected or buggy dtype conversions labels Oct 17, 2020
@jreback jreback added this to the 1.2 milestone Oct 17, 2020
@jreback jreback merged commit 32225b0 into pandas-dev:master Oct 17, 2020
@jreback
Copy link
Contributor

jreback commented Oct 17, 2020

great thanks @arw2019

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Dtype Conversions Unexpected or buggy dtype conversions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants