TST: insert 'match' to bare pytest raises in pandas/tests/tseries/off… #36682
Conversation
|
Please have look at this PR. I am new to this, I have tried to follow guidelines as much as possible. FYI @MomIsBestFriend |
| "cls, left, right, comparison", | ||
| [ | ||
| (cls, left, right, comparison) | ||
| for cls in tick_classes |
There was a problem hiding this comment.
We don't want for loops inside the parameters, parametrizing is already a type of for loop. If you check some of the other examples in the code base it might become a bit more clear.
There was a problem hiding this comment.
i will have look at this. I used this as left, right arguments were dependent on cls vlaue.
There was a problem hiding this comment.
Ah I missed that part, maybe parametrizing isn't as clean as I thought
There was a problem hiding this comment.
so should i remove it from left and right. And keep it only for cls and comparison.
There was a problem hiding this comment.
For now I suppose just adding that error message should be good for this PR (any other cleanup could always be done as follow-up). Sorry for the confusion.
…sets/test_ticks.py
…sets/test_ticks.py (pandas-dev#36682)
3 participants
…sets/test_ticks.py
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffref: #30999