Skip to content

CLN: Index._format_with_header (remove kwargs etc.) #35118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

CLN: Index._format_with_header (remove kwargs etc.) #35118

merged 2 commits into from
Jul 7, 2020

Conversation

@topper-123
Copy link
Contributor

@topper-123 topper-123 commented Jul 3, 2020 •
edited
Loading

Refactor of Index._format_with_header and subclass methods:

  • remove kwargs for cleaner signature.
  • Add return type
  • Move functionality specific to CategoricalIndex to that class.

@jbrockmendel
Copy link
Member

jbrockmendel commented Jul 4, 2020

LGTM

@topper-123 topper-123 mentioned this pull request Jul 4, 2020
Merged
@topper-123 topper-123 added Index Related to the Index class or subclasses Clean labels Jul 4, 2020
@topper-123 topper-123 added this to the 1.1 milestone Jul 4, 2020
@jreback jreback merged commit 031fb16 into pandas-dev:master Jul 7, 2020
@jreback
Copy link
Contributor

jreback commented Jul 7, 2020

thanks @topper-123

@simonjayhawkins simonjayhawkins mentioned this pull request Jul 30, 2020
Merged
5 tasks
@topper-123 topper-123 deleted the cln_Index._format_with_header branch August 8, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Clean Index Related to the Index class or subclasses

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@topper-123 @jbrockmendel @jreback