Skip to content

CI: Fail on warning for 3.9 #34852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger wants to merge 3 commits into from
Closed

CI: Fail on warning for 3.9 #34852

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36af9c5
CI: Fail on warning for 3.9
TomAugspurger Jun 17, 2020
dd9c486
try setup.cfg
TomAugspurger Jun 17, 2020
6cae5f8
Merge remote-tracking branch 'upstream/master' into 39-werror
TomAugspurger Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ matrix:
- dist: bionic
python: 3.9-dev
env:
- JOB="3.9-dev" PATTERN="(not slow and not network and not clipboard)"
- JOB="3.9-dev" PATTERN="(not slow and not network and not clipboard)" TEST_ARGS="-Werror"
Copy link
Member

@WillAyd WillAyd Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets passed to pytest right? I think the flag there is just -W

https://docs.pytest.org/en/latest/warnings.html

Copy link
Member

@WillAyd WillAyd Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or could even do in the setup.cfg

Copy link
Contributor Author

@TomAugspurger TomAugspurger Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it out in setup.cfg. The primary issue I see is that we don't necessarily want warnings from optional dependencies to cause errors. For now I've limited to just our required dependencies.

- env:
- JOB="3.8" ENV_FILE="ci/deps/travis-38.yaml" PATTERN="(not slow and not network and not clipboard)"

Expand Down