TYP: disallow decorator preserves function signature #33521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
WillAyd
reviewed
Apr 22, 2020
pandas/core/frame.py
Outdated
| # indices will always be np.ndarray since axis is not None and | ||
| # values is a 2d array for DataFrame | ||
| # error: Item "int" of "Union[int, Any]" has no attribute "__iter__" | ||
| indices = cast(np.ndarray, indices) |
There was a problem hiding this comment.
What’s the reasoning here for cast instead of assert? The latter is generally easier to refactor
There was a problem hiding this comment.
@WillAyd is this concern a blocker?
|
can u rebase |
|
thanks @simonjayhawkins |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #33455