TST: Don't use 'is' on strings to avoid SyntaxWarning #33322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Apr 6, 2020
jreback
added
Compat
Contributor
|
thanks @rebecca-palmer |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 11, 2020
raspbian-autopush
pushed a commit
to raspbian-packages/pandas
that referenced
this pull request
May 10, 2020
It causes a SyntaxWarning on install, and possibly undefined test results Author: Rebecca N. Palmer <[email protected]> Bug-Debian: https://bugs.debian.org/956021 Forwarded: pandas-dev/pandas#33322 Gbp-Pq: Name fix_is_warnings.patch
raspbian-autopush
pushed a commit
to raspbian-packages/pandas
that referenced
this pull request
Jul 2, 2020
It causes a SyntaxWarning on install, and possibly undefined test results Author: Rebecca N. Palmer <[email protected]> Bug-Debian: https://bugs.debian.org/956021 Forwarded: pandas-dev/pandas#33322 Gbp-Pq: Name fix_is_warnings.patch
raspbian-autopush
pushed a commit
to raspbian-packages/pandas
that referenced
this pull request
Aug 20, 2020
It causes a SyntaxWarning on install, and possibly undefined test results Author: Rebecca N. Palmer <[email protected]> Bug-Debian: https://bugs.debian.org/956021 Forwarded: pandas-dev/pandas#33322 Gbp-Pq: Name fix_is_warnings.patch
raspbian-autopush
pushed a commit
to raspbian-packages/pandas
that referenced
this pull request
Aug 31, 2020
It causes a SyntaxWarning on install, and possibly undefined test results Author: Rebecca N. Palmer <[email protected]> Bug-Debian: https://bugs.debian.org/956021 Forwarded: pandas-dev/pandas#33322 Gbp-Pq: Name fix_is_warnings.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the below warning (in Python 3.8, user-visible in Debian because they byte-compile everything on install), and possibly unspecified behaviour (though I haven't seen that in practice).