Skip to content

API/CLN: simplify CategoricalBlock.replace #33279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

API/CLN: simplify CategoricalBlock.replace #33279

merged 1 commit into from
Apr 6, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 4, 2020

Makes DataFrame.replace on Categorical behave like Series.replace.

@jbrockmendel jbrockmendel mentioned this pull request Apr 5, 2020
Open
@jreback jreback added Categorical Categorical Data Type Internals Related to non-user accessible pandas implementation labels Apr 5, 2020
@jreback jreback added this to the 1.1 milestone Apr 5, 2020
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Apr 6, 2020

The follow-up to this lets us get the filter kwarg out of BlockManager.apply

@jreback jreback merged commit fd9ec6c into pandas-dev:master Apr 6, 2020
@jbrockmendel jbrockmendel deleted the ea-replace branch April 6, 2020 21:26
@jbrockmendel jbrockmendel mentioned this pull request Apr 6, 2020
Merged
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Apr 11, 2020
@jbrockmendel
API/CLN: simplify CategoricalBlock.replace (pandas-dev#33279)
c57f6e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Categorical Categorical Data Type Internals Related to non-user accessible pandas implementation

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

HUH?: DataFrame[categorical].replace

2 participants

@jbrockmendel @jreback