Skip to content

BUG: pickle files left behind by tm.round_trip_pickle #30906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2020
Merged

BUG: pickle files left behind by tm.round_trip_pickle #30906

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a97b6d1
BUG: pickle files ensure_clean
jbrockmendel Jan 11, 2020
badd4f1
mypy fixup
jbrockmendel Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/_testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ def round_trip_pickle(
if _path is None:
_path = f"__{rands(10)}__.pickle"
with ensure_clean(_path) as path:
pd.to_pickle(obj, _path)
return pd.read_pickle(_path)
pd.to_pickle(obj, path)
return pd.read_pickle(path)


def round_trip_pathlib(writer, reader, path: Optional[str] = None):
Expand Down