DOC: whatsnew fixes #30836
DOC: whatsnew fixes #30836
Conversation
doc/source/whatsnew/v1.0.0.rst
Outdated
| ~~~~~~~~~~~~ | ||
|
|
||
| .. _whatsnew_100.NA: | ||
| .. _whatsnew_1000.NA: |
There was a problem hiding this comment.
All of the other headings are _1000 so making these consistent
There was a problem hiding this comment.
hmm, i think they should all be 100, right?
There was a problem hiding this comment.
Ah, yeah, the four digits are probably carry over from when we did "0250" for 0.25.0. Will switch back to 100 and convert the 1000's.
There was a problem hiding this comment.
I guess one argument for keeping 1000 is if we intend to go up to 1.10.0 or beyond. Probably not a big issue either way, so will leave as 100 unless there's a strong objection.
doc/source/whatsnew/v1.0.0.rst
Outdated
| - Removed :meth:`DataFrame.as_matrix`, :meth:`Series.as_matrix` (:issue:`18458`) | ||
| - Removed :meth:`Series.asobject` (:issue:`18477`) | ||
| - Removed :meth:`DataFrame.as_blocks`, :meth:`Series.as_blocks`, `DataFrame.blocks`, :meth:`Series.blocks` (:issue:`17656`) | ||
| - Removed :meth:`DataFrame.as_blocks`, :meth:`Series.as_blocks`, :attr:`DataFrame.blocks`, :attr:`Series.blocks` (:issue:`17656`) |
There was a problem hiding this comment.
i don't think these work on removed functions / attrivutes
There was a problem hiding this comment.
Yeah, they don't. This is true for most of the references in this section.
There was a problem hiding this comment.
yep, might as well remove the references (but prob doesn't hurt much either)
There was a problem hiding this comment.
okay, went through the entire section and deleted the references from from things that have been removed
|
Thanks! |
3 participants
Some small fixes I noticed reading over the whatsnew.