Skip to content

Conversation

@Ynob2000
Copy link
Contributor

@Ynob2000 Ynob2000 commented Dec 12, 2019

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a whatsnew note as well (bug fixes / grouping) for 1.0

@Ynob2000 Ynob2000 requested a review from jreback December 12, 2019 15:27
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging master should fix the CI failures.

Ynob2000 and others added 3 commits December 12, 2019 21:33
@pep8speaks
Copy link

pep8speaks commented Dec 13, 2019

Hello @nlepleux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-13 15:23:08 UTC

@Ynob2000
Copy link
Contributor Author

It is possible to restart the CI process? The git checkout failed on windows

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ping on green.

@jreback jreback added this to the 1.0 milestone Dec 13, 2019
@Ynob2000 Ynob2000 requested a review from jreback December 13, 2019 15:41
@Ynob2000
Copy link
Contributor Author

all green

@WillAyd WillAyd merged commit c3c85c1 into pandas-dev:master Dec 13, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 13, 2019

Great thanks @nlepleux

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groupby crash on a single level

5 participants