CLN: OrderedDict -> Dict

[alimcmaster1]

• xref CLN: OrderedDict -> Dict #30469
• follow up from CI: Drop Python 3.5 support #29212
• passes black pandas

As of CPython 3.6 the implementation of dict maintains insertion order.

This became a language feature in python 3.7.

Note in python 3.8 support for reversed(dict) was added - but we don't seem to use that in the use cases i've eliminated.

There is more to do here.

[topper-123]

Can you use dict literals where possible, i.e. {"": (0, 0)} dict((("", (0, 0)),)) etc.

Else LGTM.

[WillAyd]

lgtm. Should maybe add a code check as well to not use OrderedDict, or is there any outstanding reason still to use?

@jreback

[jreback]

@alimcmaster1 yeah lgtm. but agree we need a code check here, can you add.

[alimcmaster1]

Thanks @topper-123 updated as per your comments. @jreback sure will add a code check in a follow up - there are still some more references to remove but ill save those for next PR

[topper-123]

A last one missing here, else looks good.

[WillAyd]

Thanks @alimcmaster1