TYP: privatize type alias in pandas/util/_decorators.py

[simonjayhawkins]

broken off #28339

[jreback]

why do you think privatizing this is warranted? (other parts are ok)

[simonjayhawkins]

It was a mistake when first added. Type aliases added directly in modules are added or the purpose of type checking only and shouldn't be public.

They should be considered an implementation detail and subject to change without notice.

All aliases in typeshed are prefixed with an underscore.

[jreback]

It was a mistake when first added. Type aliases added directly in modules are added or the purpose of type checking only and shouldn't be public.

They should be considered an implementation detail and subject to change without notice.

All aliases in typeshed are prefixed with an underscore.

this entire module is private and this is inconsistent with the rest of the codebase where a type annotation is just a name; private just makes this harder to read.

[simonjayhawkins]

so should I close this then?

[jreback]

so should I close this then?

i don't see any other changes? if so, yes

do we have this pattern elsewhere? we should be consistent about it (I think we mostly are already)

[simonjayhawkins]

i don't see any other changes? if so, yes

one other minor change, i'll include in future PR instead.

do we have this pattern elsewhere?

just #29755 (comment), could be reverted.

used heavily in #28339, but will change as break bits off

we should be consistent about it

agreed. so this module being private is probably not relevant. We should not privatize aliases in any modules

(I think we mostly are already)

not really used many aliases outside of pd._typing yet