Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 17, 2019

just make it a function instead of adding n flags.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 17, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 17, 2019
@jreback
Copy link
Contributor

jreback commented Jun 17, 2019

seems fine. ping on green.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #26901 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26901      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50712    50716       +4     
==========================================
  Hits        46590    46590              
- Misses       4122     4126       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 41.1% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 93.65% <100%> (+0.43%) ⬆️
pandas/compat/numpy/__init__.py 93.1% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa77c3...c8ef59d. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #26901 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26901      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50712    50716       +4     
==========================================
  Hits        46590    46590              
- Misses       4122     4126       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 41.1% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 93.65% <100%> (+0.43%) ⬆️
pandas/compat/numpy/__init__.py 93.1% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa77c3...c8ef59d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #26901 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26901      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50712    50716       +4     
==========================================
  Hits        46590    46590              
- Misses       4122     4126       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 41.1% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 93.65% <100%> (+0.43%) ⬆️
pandas/compat/numpy/__init__.py 93.1% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa77c3...c8ef59d. Read the comment docs.

@ghost ghost mentioned this pull request Jun 17, 2019
5 tasks
@ghost
Copy link
Author

ghost commented Jun 17, 2019

@jreback green.

@jorisvandenbossche jorisvandenbossche merged commit 77e6556 into pandas-dev:master Jun 18, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

@ghost ghost deleted the fix_td_decorator branch June 19, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants