Skip to content

Add tests for NaT when performing dt.to_period #24921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Add tests for NaT when performing dt.to_period #24921

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
875a3c4
Add tests for NaT when performing dt.to_period
alexander-ponomaroff Jan 25, 2019
8cb340a
Parameterize the test and compare result to expected
alexander-ponomaroff Jan 25, 2019
3831f86
Improve to_period test
alexander-ponomaroff Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/tests/series/test_period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,10 @@ def test_end_time_timevalues(self, input_vals):
result = s.dt.end_time
expected = s.apply(lambda x: x.end_time)
tm.assert_series_equal(result, expected)

def test_to_period(self):
series = pd.Series(['2001'], dtype='datetime64[ns]')
assert series.dt.to_period('D').dtype == 'Period[D]'

series = pd.Series(['NaT'], dtype='datetime64[ns]')
assert series.dt.to_period('D').dtype == 'Period[D]'