Skip to content

CI: Check in the CI that assert_raises_regex is not being used #23627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfyoung merged 3 commits into from
Nov 12, 2018
Merged

CI: Check in the CI that assert_raises_regex is not being used #23627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dd8cdd
Check in the CI that assert_raises_regex is not being used
datapythonista Nov 11, 2018
da8b244
Reversing the result of the grep
datapythonista Nov 11, 2018
1fea3a4
Excluding .pyc files from the new check
datapythonista Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then
! grep -R --include="*.py" --include="*.pyx" --include="*.rst" -E "\.\. (autosummary|contents|currentmodule|deprecated|function|image|important|include|ipython|literalinclude|math|module|note|raw|seealso|toctree|versionadded|versionchanged|warning):[^:]" ./pandas ./doc/source
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Check that the deprecated `assert_raises_regex` is not used (`pytest.raises(match=pattern)` should be used instead)' ; echo $MSG
! grep -R --exclude=*.pyc --exclude=testing.py --exclude=test_testing.py assert_raises_regex pandas
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Check for modules that pandas should not import' ; echo $MSG
python -c "
import sys
Expand Down