Skip to content

Conversation

@jbrockmendel
Copy link
Member

Since they are no longer defined there; instead import then from more appropriate places.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #23562 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23562   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51224    51224           
=======================================
  Hits        47254    47254           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 42.28% <57.14%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.81% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8212001...bf7249d. Read the comment docs.

@jbrockmendel jbrockmendel changed the title remove uses of (ts?)lib.(NaT|iNaT|Timestamp) remove uses of (ts)?lib.(NaT|iNaT|Timestamp) Nov 8, 2018
@gfyoung gfyoung added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Nov 8, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice regex-ish title as well. 🙂

cc @jreback

@jreback jreback added this to the 0.24.0 milestone Nov 8, 2018
@jreback jreback merged commit 712fa94 into pandas-dev:master Nov 8, 2018
@jreback
Copy link
Contributor

jreback commented Nov 8, 2018

thanks!

@jbrockmendel jbrockmendel deleted the cln2 branch November 8, 2018 14:48
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants