ENH: Let Resampler objects have a pipe method#18940
Merged
jreback merged 1 commit intopandas-dev:masterfrom Dec 26, 2017
Merged
ENH: Let Resampler objects have a pipe method#18940jreback merged 1 commit intopandas-dev:masterfrom
jreback merged 1 commit intopandas-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18940 +/- ##
==========================================
+ Coverage 91.59% 91.59% +<.01%
==========================================
Files 150 150
Lines 48959 48964 +5
==========================================
+ Hits 44845 44850 +5
Misses 4114 4114
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
Resampler_pipe
branch
2 times, most recently
from
5ec26be to
b6f8834
Compare
topper-123
changed the title
topper-123
force-pushed
the
Resampler_pipe
branch
from
b6f8834 to
30f91be
Compare
Contributor
|
nice @topper-123 thanks! |
hexgnu
pushed a commit
to hexgnu/pandas
that referenced
this pull request
Dec 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffCurrently, calls to
df.resample(....).pipe(...)are converted todf.resample(....).mean().pipe(...)and a warning is emitted (see #17905).This PR solves this by moving the
pipemethod from theGroupByclass to the_GroupByclass. As_GroupByis a common parent class of bothGroupByandResampler, thepipemethod is now available forResamplertoo.See also #17871.