Skip to content

Conversation

@jbrockmendel
Copy link
Member

Once #17793 is merged then the remaining timedeltas functions can be moved: convert_to_timedelta64 and array_to_timedelta64.

Most of Timedelta and _Timedelta can also be moved over in a follow up.

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #17827 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17827      +/-   ##
==========================================
+ Coverage   91.23%   91.24%   +<.01%     
==========================================
  Files         163      163              
  Lines       50113    50113              
==========================================
+ Hits        45723    45726       +3     
+ Misses       4390     4387       -3
Flag Coverage Δ
#multiple 89.05% <ø> (+0.02%) ⬆️
#single 40.31% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b4bb3...fb907b6. Read the comment docs.

@jreback jreback added Clean Timedelta Timedelta data type labels Oct 10, 2017
@jbrockmendel
Copy link
Member Author

This is cut/paste, can be cut down if the diff is too large for easy review.

@jreback
Copy link
Contributor

jreback commented Oct 20, 2017

looks ok, needs a rebase

@jreback jreback added this to the 0.21.0 milestone Oct 21, 2017
@jreback
Copy link
Contributor

jreback commented Oct 21, 2017

thanks!

@jreback jreback merged commit 058da72 into pandas-dev:master Oct 21, 2017
@jbrockmendel jbrockmendel deleted the tslibs-timedeltas4 branch October 27, 2017 22:11
peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Timedelta Timedelta data type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants