Skip to content

Conversation

@matthewwillian
Copy link

@matthewwillian matthewwillian changed the title Finite BUG: Handle infinite values correctly in Series.argmax Jul 11, 2016
- Bug when specifying a UTC ``DatetimeIndex`` by setting ``utc=True`` in ``.to_datetime`` (:issue:`11934`)
- Bug when increasing the buffer size of CSV reader in ``read_csv`` (:issue:`12494`)
- Bug when setting columns of a ``DataFrame`` with duplicate column names (:issue:`12344`)
- Bug when calling Series.argmax with infinite values (:issue: `13595`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to 0.19.0

@sinhrks sinhrks added Bug Numeric Operations Arithmetic, Comparison, and Logical operations labels Jul 12, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 12, 2016

- Bug where ``pd.read_gbq()`` could throw ``ImportError: No module named discovery`` as a result of a naming conflict with another python package called apiclient (:issue:`13454`)

- Bug when calling Series.argmax with infinite values (:issue: `13595`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use double-back ticks around Series.argmax

no space after ``:issue:13595)

@jorisvandenbossche
Copy link
Member

@matthewwillian You have some PEP8 issues (see the travis log at the bottom: https://travis-ci.org/pydata/pandas/jobs/144182270), and a failing test.

@matthewwillian
Copy link
Author

Okay, thank you. I will take a look.

@jorisvandenbossche
Copy link
Member

@matthewwillian Can you update/rebase?

@sinhrks
Copy link
Member

sinhrks commented Jul 24, 2016

It's great if you can include the fix for argmin for -inf.

pd.Series([1, 3, -np.inf]).argmin()
0

@jreback
Copy link
Contributor

jreback commented Aug 18, 2016

can you rebase

@jreback jreback removed this from the 0.19.0 milestone Aug 18, 2016
@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

can you rebase / update?

@jreback
Copy link
Contributor

jreback commented Nov 16, 2016

can you rebase and move release notes to 0.19.2

@jreback
Copy link
Contributor

jreback commented Dec 21, 2016

can you rebase / update

@jreback
Copy link
Contributor

jreback commented Dec 30, 2016

closing, but if you want to update, pls comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Numeric Operations Arithmetic, Comparison, and Logical operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Series.argmax() fails with np.inf

4 participants