-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Closed
Labels
API - ConsistencyInternal Consistency of API/BehaviorInternal Consistency of API/BehaviorEnhancementsetopsunion, intersection, difference, symmetric_differenceunion, intersection, difference, symmetric_difference
Description
As part of #22811 I added a sort parameter to the difference set operation with a default of True. The other set operations do not have this parameter but some of them sort by default if possible. Should we add a sort parameter to the other set operations too if possible for consistency?
TODO:
- 0.24.0 DateTimeIndex: union() got an unexpected keyword argument 'sort' 0.24.0 DateTimeIndex: union() got an unexpected keyword argument 'sort' #24994
- TimedeltaIndex.intersection has no
sortoption. TimedeltaIndex.intersection has nosortoption. #24966 - Check if we can implement the
sortparameter forRangeIndex.union(ENH: Add sort parameter to RangeIndex.union (#24471) #25788) - Decide the sort behaviour when the two Indexes are equal or one of the two Indexes are empty
- Review all set operation tests and ensure that all corner cases are being tested and that sort behaviour is actually being tested (e.g., pass Indexes that are not already sorted to tests)
- Implement
sort=Trueand deprecatesort=Nonein future release?
Metadata
Metadata
Assignees
Labels
API - ConsistencyInternal Consistency of API/BehaviorInternal Consistency of API/BehaviorEnhancementsetopsunion, intersection, difference, symmetric_differenceunion, intersection, difference, symmetric_difference