Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade release script to go 1.20 #193

Merged

Conversation

MechanicalTyler
Copy link
Contributor

@MechanicalTyler MechanicalTyler commented Jun 19, 2023

The release is currently broken due to the most recent upgraded dependencies. We are getting this error:

/go/pkg/mod/github.com/cosmos/[email protected]/types/address.go:88:26: undefined: atomic.Bool
note: module requires Go 1.19
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter.go:118:15: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter_float64.go:119:19: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter_float64.go:147:35: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/ewma.go:78:19: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/gauge.go:104:15: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/gauge_float64.go:89:19: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/meter.go:104:40: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/meter.go:172:21: undefined: atomic.Bool
note: module requires Go 1.19
/go/pkg/mod/github.com/ethereum/[email protected]/core/vm/evm.go:117:15: undefined: atomic.Bool
note: module requires Go 1.19

We should go ahead and upgrade to 1.20 to be at the most recent

Tyler Ruppert added 2 commits June 19, 2023 12:55
The release is currently broken due to the most recent upgraded
dependencies.  We are getting this error:

```
/go/pkg/mod/github.com/cosmos/[email protected]/types/address.go:88:26: undefined: atomic.Bool
note: module requires Go 1.19
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter.go:118:15: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter_float64.go:119:19: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/counter_float64.go:147:35: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/ewma.go:78:19: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/gauge.go:104:15: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/gauge_float64.go:89:19: undefined: atomic.Uint64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/meter.go:104:40: undefined: atomic.Int64
/go/pkg/mod/github.com/ethereum/[email protected]/metrics/meter.go:172:21: undefined: atomic.Bool
note: module requires Go 1.19
/go/pkg/mod/github.com/ethereum/[email protected]/core/vm/evm.go:117:15: undefined: atomic.Bool
note: module requires Go 1.19
```

We should go ahead and upgrade to 1.20 to be at the most recent
@taariq taariq merged commit e9def01 into palomachain:release/v1.2.1 Jun 19, 2023
@taariq taariq deleted the toaster/upgrade-release-golang branch June 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants