Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling ValsetID getter function from compass, rather than filtering events #129

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Calling ValsetID getter function from compass, rather than filtering events #129

merged 2 commits into from
Mar 24, 2023

Conversation

mszuyev
Copy link
Contributor

@mszuyev mszuyev commented Mar 24, 2023

Related Github tickets

Background

Fixing performance issue when querying last valset ID

@mszuyev mszuyev requested review from webelf101 and taariq March 24, 2023 06:55
taariq
taariq approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Good to see the abi-gen working here in the build. It makes it easier for any dev to add additional ABIs for Pigeon.

@taariq taariq merged commit c0b920b into palomachain:master Mar 24, 2023
@taariq taariq deleted the mz/use-generated-client-code branch March 24, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taariq taariq taariq approved these changes

@webelf101 webelf101 Awaiting requested review from webelf101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszuyev @taariq