test: expect 200 status #16
Conversation
|
@henriklundgren, thanks for your first contribution. The issue has something to do with the way we look for the main package.json file. Do you know if that part could be implemented in a different way? |
|
I guess just use https://github.com/sindresorhus/pkg-dir. Edit: |
henriklundgren
force-pushed
the
test/fails-on-jest
branch
from
e5d8d1a to
ccdb307
Compare
| if (error) { | ||
| diskInfo = {msg: 'Error fetching disk info', error: error}; | ||
| } | ||
| pkgDir(path.resolve(__dirname, '../')).then(function(x) { |
There was a problem hiding this comment.
Still not sure about whether this works when you use express-ping as a module in a bigger project that contains its own package.json. Which package.json file would this code find? The one that belongs to express-ping or the one that belongs to the bigger project?
It fails on Jest unfortunately,
the reason is jestjs/jest#2150.
I dont know if the best course of action is to wait and see if Jest updates,
or if other test framework also fails then maybe write a different implementation.