Add unit tests to show, that encoding parameter in open_resource method is required #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Jul 10, 2024
tests/test_helpers.py
Outdated
| os.remove("tests/static/test.txt") | ||
|
|
||
| with open("tests/static/test.txt", "w", encoding=encoding) as f: | ||
| f.write("" + "Hello World!") |
There was a problem hiding this comment.
Is that an empty string or something non-printable/zero-width? If it's the latter, please use an escape sequence instead so it's clear it's not something useless.
for more information, see https://pre-commit.ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this PR so you can see the necessity of fixing issue #5504
Tests are marked as skipped, so it will not break.