Fixes for PEP451 import loaders and pytest 5.x#3278
Merged
davidism merged 1 commit intopallets:1.0.xfrom Jul 1, 2019
asottile:importlib_spec
Merged
Fixes for PEP451 import loaders and pytest 5.x#3278davidism merged 1 commit intopallets:1.0.xfrom asottile:importlib_spec
davidism merged 1 commit intopallets:1.0.xfrom
asottile:importlib_spec
Conversation
Closed
Contributor
Author
|
oof, let me figure out the pypy3 failure :S |
Contributor
Author
|
hmmm weird, on pypy3 it's detecting |
Contributor
Author
|
ok I'm slightly wrong about the namespace package classification -- that appears to be a bug in pypy: https://bitbucket.org/pypy/pypy/issues/3034/egg-__spec__-is-none-if-queried-while |
Contributor
Author
|
actually, let me try another approach that makes pypy less special |
Contributor
Author
|
ok, I'm happy with this implementation now |
- pytest 5.x drops python2 compatibility and therefore only implements PEP 451 - pytest 5.x made the repr of `ExcInfo` less confusing (fixed tests depending on the old format)
Member
|
Thanks! Fixed a naming issue, all envs should pass now. |
Contributor
Author
|
awesome thanks for the fixup! stepped out for a run and totally missed that 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExcInfoless confusing (fixed tests dependingon the old format)
Resolves #3275
Resolves #3277