Skip to content

Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default#727

Merged
davidism merged 1 commit intopallets-eco:masterfrom
lbeaufort:699-default-track-modifications-to-false
May 8, 2019
Merged

Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default#727
davidism merged 1 commit intopallets-eco:masterfrom
lbeaufort:699-default-track-modifications-to-false

Conversation

@lbeaufort
Copy link
Contributor

@lbeaufort lbeaufort commented May 6, 2019 •
edited
Loading

Resolves #699

  • Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default
  • Update tests to reflect new behavior
  • Update pytest configuration to no longer set app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
  • Update docs to reflect new default

@lbeaufort lbeaufort changed the title [WIP] Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default May 6, 2019
singingwolfboy
singingwolfboy approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@singingwolfboy singingwolfboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lbeaufort lbeaufort changed the base branch from master to 2.x May 6, 2019 21:05
@lbeaufort lbeaufort changed the base branch from 2.x to master May 6, 2019 21:05
@lbeaufort lbeaufort force-pushed the 699-default-track-modifications-to-false branch from 26bb4be to 9163259 Compare May 6, 2019 21:07
@rsyring rsyring added this to the 3.0 milestone May 6, 2019
@lbeaufort lbeaufort changed the title Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default [WIP] Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default May 7, 2019
@lbeaufort
Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default
2d40657 
- Update default value
- Update tests
- Update docs
@lbeaufort lbeaufort force-pushed the 699-default-track-modifications-to-false branch from 9163259 to 2d40657 Compare May 7, 2019 13:15
@lbeaufort lbeaufort changed the title [WIP] Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default May 7, 2019
@lbeaufort
Copy link
Contributor Author

lbeaufort commented May 7, 2019 •
edited
Loading

@singingwolfboy thanks for taking a look! I updated the docs since your last review in case you'd like to take another look.

@davidism davidism merged commit 95f5012 into pallets-eco:master May 8, 2019
@lbeaufort lbeaufort deleted the 699-default-track-modifications-to-false branch May 8, 2019 16:31
This was referenced May 8, 2019
Merged
Closed
@michamos michamos mentioned this pull request Jun 6, 2019
Closed
jeffwidman added a commit to pallets-eco/flask-debugtoolbar that referenced this pull request Feb 18, 2020
@jeffwidman
Explicitly disable SQLALCHEMY_TRACK_MODIFICATIONS
9c7db48 
This silences deprecation warnings.
Background: https://stackoverflow.com/a/33790196/770425

Note: This code can be removed once `flask_sqlalchemy` 3.0 ships, or any
release that includes
pallets-eco/flask-sqlalchemy#727.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@singingwolfboy singingwolfboy singingwolfboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Set SQLALCHEMY_TRACK_MODIFICATIONS to False by default

4 participants

@lbeaufort @singingwolfboy @rsyring @davidism

Comments