Allow user-specified Model base classes#72
Closed
jfinkels wants to merge 1 commit intopallets-eco:masterfrom
jfinkels:master
Closed
Allow user-specified Model base classes#72jfinkels wants to merge 1 commit intopallets-eco:masterfrom jfinkels:master
jfinkels wants to merge 1 commit intopallets-eco:masterfrom
jfinkels:master
Conversation
|
+1 |
7 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
-1 if you needed the db.Model inside the Base, that's a different thing. |
|
agree with @jamesonjlee . 👎 |
Member
|
Extending this to allow other custom bases such as DeclarativeMeta, BaseQuery, etc. would be really useful. Right now I end up subclassing and overriding the extension to use custom classes. |
Contributor
|
👍 - this would still be increadibly useful and avoid nasty monkeypatching! Using mixins instead is not a very good idea. You need to put them in every single model explictly even if you just want to add convenience methods which you do want in all your models. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to issue #62. It allows a user to specify a base class for models (which should be a subclass of
flaskext.sqlalchemy.Model) in the constructor offlaskext.sqlalchemy.SQLALchemy. Note: this does not work with theSQLAlchemy.init_app(app)idiom unless the model class is specified in the constructor ofSQLAlchemy.