Skip to content

WIP Support testing with PostgreSQL#647

Closed
puntonim wants to merge 1 commit intopallets-eco:masterfrom
puntonim:test-w-postgresql
Closed

WIP Support testing with PostgreSQL#647
puntonim wants to merge 1 commit intopallets-eco:masterfrom
puntonim:test-w-postgresql

Conversation

@puntonim
Copy link

No description provided.

@ThiefMaster
Copy link
Contributor

ThiefMaster commented Oct 15, 2018

Thanks, but I don't see the point here; Flask-SQLAlchemy is just a thin wrapper for SQLAlchemy, no need to test it with different databases...

@puntonim
Copy link
Author

Flask-SQLAlchemy behaves slightly differently with different db engines. This, indeed, only happens with some features like signals: see what @michamos found here: #646

Also, look at the current state of this PR (https://travis-ci.org/mitsuhiko/flask-sqlalchemy/builds/441787060?utm_source=github_status&utm_medium=notification): some tests fail when tested against PostgreSQL.
Do you see the point?

@puntonim
Copy link
Author

What do you think @davidism ?

@davidism
Copy link
Member

Thanks for you're interest. At this time, I don't think the utility of these tests justifies the extra overhead in terms of test time and maintenance.

This adds a lot of overhead to run all tests in all environments with the only change being the database backend, which is already tested by SQLAlchemy. None of the current driver hacks apply to PostgreSQL.

From what I've seen of SQLAlchemy's test suite, I absolutely do not want to take on testing against multiple database backends unless absolutely necessary.

One of the failures is that PyPy can't use Psycopg2 due to C API. The other is against CPython nightly, and doesn't appear related to Flask-SQLAlchemy.

@puntonim
Copy link
Author

Ok it makes sense, then I'll close this 😄

@puntonim puntonim closed this Oct 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments