Optional count of total number of pages#613
Merged
davidism merged 2 commits intopallets-eco:masterfrom Mar 30, 2018
Merged
Conversation
trollefson
force-pushed
the
opt_page_len_count
branch
2 times, most recently
from
137a24a to
0c3bf58
Compare
Contributor
|
Please don't do version bumps in PRs. This change does not look like something qualifying for an immediate release (neither an urgent bug nor a security issue) |
Member
|
Don't bump version numbers in PRs. (Also, "released March 30" is unrealistically optimistic.) |
Contributor
Author
|
No problem. I'll revert the version bump. I wasn't sure on the protocol. |
trollefson
force-pushed
the
opt_page_len_count
branch
from
0c3bf58 to
9a3a2df
Compare
Contributor
Author
|
Build fails on Python 2.6. Related: |
Member
|
Needs documentation, otherwise looks good. |
Contributor
Author
|
Doc string updated |
trollefson
changed the title
Contributor
|
Looks like this could go into a 2.x release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counting the length of a table can be slow on large tables This PR makes that counting optional and is backwards compatible.
Related:
#518
#281