Clean up tests, more thorough version testing#388
Merged
Conversation
* SQLALCHEMY_ENGINE isn't a config key * SQLALCHEMY_DATABASE_URI defaults to sqlite:// * not all TestCases registered, some fail * flask_sqlalchemy is aliased to sqlalchemy, confusing * tox with min and current versions
Member
Author
|
Ignore the failed ci build, I think it got confused between the initial push and the pr. It does pass: https://travis-ci.org/mitsuhiko/flask-sqlalchemy/builds/121980819. |
This was referenced Apr 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLALCHEMY_ENGINEisn't a config key, so the defaultsqlite://was being used.SQLALCHEMY_DATABASE_URIdefaults tosqlite://anyway, so just remove all these configsCustomQueryClassTestCasewasn't registeredCustomQueryClassTestCase.test_dont_override_model_defaultwasn't testing the right thing, and was also failingCustomModelClassTestCasewasn't registeredconnected_to, replace withconnectanddisconnectimport flask_sqlalchemy as sqlalchemyis a confusing alias, usedfsainstead