Have the SQLALCHEMY_RECORD_QUERIES setting take precedence over DEBUG#320
Have the SQLALCHEMY_RECORD_QUERIES setting take precedence over DEBUG#320csdev wants to merge 2 commits intopallets-eco:mainfrom
Conversation
This allows query recording to be disabled regardless of the other application settings
|
You know that documentation says that queries are always recorded in debug mode? maybe the pull request should also change the documentation ( if it gets accepted ) |
|
@immunda that is definitely a valid concern. This is a change in application behavior that should probably wait for a major release. The reason I am proposing it is because it would be nice to disable query recording even though debug mode is on. In one of my projects, we have some database tasks that run a large set of queries. We have found that query recording can use up an excessive amount of memory. @bastianh I will take a look at the docs later and add those changes to the pull request. |
|
Dupe of #186 (although I prefer this version as it also updates the docs) |
|
Thank you for your contribution and sorry this reply is so long in coming. Setting the milestone for this PR to 3.0 since it changes observable behavior. |
|
This is fixed in #1087. However, I'm considering removing the automatic behavior and always requiring the config to be set. |
This allows query recording to be disabled regardless of the other application settings