release candidate 0.6.0-rc1 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Redis / mongo/memcache/filesystem Not for sql Do not save session on each request if session.modified = False
- Marked previously failing tests as SKIP as fixing them is outside the scope of this issue. - Updated pyproject.toml to be able to run the tests - Updated github actions to run tests
- Tests moved to tests directory - Testing done via pytest - Created requirements/pytest.txt for running pytest - Main code changes based on review
newline
add should_set_cookie check before save new cookies
Previous lack of SECRET_KEY with SESSION_USE_SIGNER=True was: AttributeError: 'NoneType' object has no attribute 'sign' Now it is: KeyError: 'SECRET_KEY must be set when SESSION_USE_SIGNER=True' Closed #189
Closes #203 Based on flask-session2 rather than other PRs as the expected behaviour would be to remove the session with no expiry
save_session method relies on checking if a session is empty to return early. This fixes the boolean evaluation of a permanent but empty session evaluating as True. Closes #193
Expect KeyError
Use secrets module for session ids
fix
Fix bare except statement
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes code from many PRs and issues over the lifetime of the project in order to fix most major issues.
Refactor in a way that aligns each backend and makes adding new backends or contributing easier.
The issues of serialization, more backends and regeneration have been left aside for now.
Tests are not yet thorough or well structured but will be done.
This is a release candidate intended for community test usage and feedback.