Ability to add options to scopes

[slavadev]

Hi! Thank you for a great gem!

What is the purpose of this pull request?

Add the ability to add options to Scopes so it can be declared like this:

scope_for :relation do |relation, with_deleted: false, whatever: 42|
  ...
end

And instead of several scopes can be created only one

It can be used this way:

authorized blabla, type: :relation, scope_options: { with_deleted: true }

authorized(blabla, type: :relation, with_deleted: true) would look better, but I don't think we need to mix policy lookup options with scope options

What changes did you make? (overview)

• Added scope_options to Behaviour#authorized
• Added scope_options to Scoping#apply_scope and made it pass to the policy only when options are present to not break existing scopes which don't expect options
• Updated existing tests to be green

Is there anything you'd like reviewers to focus on?

If you like the idea and the syntax, I'll add specs, documentation, and changelog for it

PR checklist:

• Tests included
• Documentation updated
• Changelog entry added

[palkan]

👍

I like the idea and the proposed implementation.

Left a few comments.

Feel free to continue with docs and changelog!

Btw, could you share your use-case (and, probably, include it into the docs)?

[palkan]

Suggestion: what if we use === here?
That would allow us to use RSpec composed matchers (like a_hash_including(...)).

[slavadev]

Updated PR, @palkan

[palkan]

Let's update an example a little bit to make it less abstract:

relation_scope do |relation, with_deleted: false|
  some_logic(relation).yield_self do |rel|
    with_deleted ? rel.with_deleted : rel
  end
end

wdyt?

[slavadev]

sure, it might help a bit with understanding

[palkan]

Thanks!