Davids/optimize #763
Open
Davids/optimize #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
schlosna
commented
Sep 23, 2025
|
|
||
| private static final String WITCHCRAFT_LOG_PATTERN_STRING = "\\{.*?\"type\"\\s*?:\\s*?\"(" | ||
| + LOG_TYPES.stream().map(Pattern::quote).collect(Collectors.joining("|")) + ")\".*?}"; | ||
| + LOG_TYPES.stream().map(Pattern::quote).collect(Collectors.joining("|")) + ")\".*?}\\s*"; |
Author
There was a problem hiding this comment.
handles matching log lines including trailing newline
schlosna
commented
Sep 23, 2025
| public void write(String str, int off, int len) { | ||
| synchronized (lock) { | ||
| for (int startIndex = off; startIndex < off + len; ) { | ||
| int newLineIndex = str.indexOf('\n', startIndex); |
Author
There was a problem hiding this comment.
this is vectorized search over underlying bytes
schlosna
commented
Sep 23, 2025
Comment on lines
+164
to
+167
| lineBuffer.append(str, startIndex, off + len); | ||
| return; | ||
| } else { | ||
| lineBuffer.append(str, startIndex, newLineIndex + 1); |
Author
There was a problem hiding this comment.
this allows bulk array copy from String to StringBuilder
schlosna
commented
Sep 23, 2025
Comment on lines
+47
to
+50
| if (delegate instanceof TestReporter testReporter) { | ||
| testReporter.generateReport(new FormattingTestResultsProvider(testResultsProvider), file); | ||
| } else if (delegate instanceof HtmlTestReport htmlTestReport) { | ||
| htmlTestReport.generateReport(new FormattingTestResultsProvider(testResultsProvider), file); |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Comments on #737
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?